Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the following bug: #2021
The bug
OR conditions in a check-level filter are not properly encapsulated, which can cause one of the OR predicates to override the other conditions in a SQL query. See the attached issue for examples: #2021
It affects:
duplicate_count
checks.The fix
I wrap parentheses around the check-level filter, e.g.
a OR b
becomes(a OR b)
.I focused on the following checks based on the documentation:
This check does not permit check-specific filters, so it is not affected by the bug.
Testing
Test - Initial Behavior
Test - Final Behavior